-
Notifications
You must be signed in to change notification settings - Fork 2k
Docs: Add manage Nomad variables page #27003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
All I have is little nits. Including this request: Can you change manage/manage-variables.mdx to manage/variables.mdx to simplify the path?
I specifically did not name it variables.mdx because there are already 2 files with that name in different directories. I dug into SEO a bit more and discovered that Google doesn't like a site that has identical file names, even in different directories. |
Co-authored-by: Jeff Boruszak <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Links
Jira: CE-974
https://nomad-git-ce974vars-hashicorp.vercel.app/nomad/docs/manage/manage-variables
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.